From e1f38c674704de4380d885f579a0ceb81a4d3bb1 Mon Sep 17 00:00:00 2001 From: hrxi Date: Sun, 8 Mar 2026 10:49:34 +0100 Subject: Remove dead callbacks in OMEMO plugin MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The callbacks aren't used by libomemo-c. The callbacks passed appear to be buggy because the return value of `gcry_md_read` is passed to `free`, but it is supposed to be automatically freed on `gcry_md_reset`. Additionally, `gcry_md_reset` is called before the return value of `gcry_md_read` is used, which is also against the documentation: https://www.gnupg.org/documentation/manuals/gcrypt-devel/Working-with-hash-algorithms.html > `gcry_md_read` returns the message digest after finalizing the > calculation. […] The returned message digest is allocated within the > message context and therefore valid until the handle is released or > reseted (using `gcry_md_close` or `gcry_md_reset`. […] --- plugins/omemo/src/native/helper.h | 4 ---- 1 file changed, 4 deletions(-) (limited to 'plugins/omemo/src/native/helper.h') diff --git a/plugins/omemo/src/native/helper.h b/plugins/omemo/src/native/helper.h index 98c96dfb..3cc21d8a 100644 --- a/plugins/omemo/src/native/helper.h +++ b/plugins/omemo/src/native/helper.h @@ -23,10 +23,6 @@ int signal_vala_hmac_sha256_init(void **hmac_context, const uint8_t *key, size_t int signal_vala_hmac_sha256_update(void *hmac_context, const uint8_t *data, size_t data_len, void *user_data); int signal_vala_hmac_sha256_final(void *hmac_context, signal_buffer **output, void *user_data); void signal_vala_hmac_sha256_cleanup(void *hmac_context, void *user_data); -int signal_vala_sha512_digest_init(void **digest_context, void *user_data); -int signal_vala_sha512_digest_update(void *digest_context, const uint8_t *data, size_t data_len, void *user_data); -int signal_vala_sha512_digest_final(void *digest_context, signal_buffer **output, void *user_data); -void signal_vala_sha512_digest_cleanup(void *digest_context, void *user_data); int signal_vala_encrypt(signal_buffer **output, int cipher, -- cgit v1.3